Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: update packet-Protocol::Handshake config url #48270

Merged
merged 1 commit into from
Nov 3, 2023
Merged

config: update packet-Protocol::Handshake config url #48270

merged 1 commit into from
Nov 3, 2023

Conversation

Defined2014
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #48203

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 3, 2023
@tiprow tiprow
Copy link

tiprow bot commented Nov 3, 2023

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov Codecov
Copy link

codecov bot commented Nov 3, 2023 •
edited
Loading

Codecov Report

Merging #48270 (1ffd30e) into master (0172ba0) will increase coverage by 1.3161%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #48270        +/-   ##
================================================
+ Coverage   71.4846%   72.8008%   +1.3161%     
================================================
  Files          1402       1425        +23     
  Lines        406266     412671      +6405     
================================================
+ Hits         290418     300428     +10010     
+ Misses        96008      93342      -2666     
+ Partials      19840      18901       -939
Flag Coverage Δ
integration 42.7278% <ø> (?)
unit 71.4914% <ø> (+0.0067%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9874% <ø> (ø)
parser ∅ <ø> (∅)
br 48.6978% <ø> (-4.2297%) ⬇️

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 3, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 3, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 3, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-03 06:11:51.074082687 +0000 UTC m=+3192708.661192817: ☑️ agreed by xhebox.
  • 2023-11-03 06:29:49.351373167 +0000 UTC m=+3193786.938483313: ☑️ agreed by zimulala.

@easonn7
Copy link

easonn7 commented Nov 3, 2023

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: easonn7, xhebox, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 3, 2023
@ti-chi-bot ti-chi-bot bot merged commit f5ac38d into pingcap:master Nov 3, 2023
14 of 16 checks passed
@Defined2014 Defined2014 deleted the fix-48203 branch March 29, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox approved these changes

@zimulala zimulala zimulala approved these changes

@hawkingrei hawkingrei Awaiting requested review from hawkingrei

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update ref link in config file
4 participants
@Defined2014 @easonn7 @zimulala @xhebox